Session id is written to ClientId? (all users count as new users?)
See original GitHub issueIm a bit confused i have a WPF application where i use GoogleAnalyticsTracker.Core
and GoogleAnalyticsTracker.Simple
, version: 4.1.40.0.
But when i use TrackAsync
it seems all users count as new users, so i looked at the source code and TrackAsync
calls this.SetRequired
which in turn calls parameters.ClientId = this.AnalyticsSession.GenerateSessionId()
and ClientId
equals to cid
and the description for cid
is:
Required for all hit types.
This anonymously identifies a particular user, device, or browser instance. For the web, this is generally stored as a first-party cookie with a two-year expiration. For mobile apps, this is randomly generated for each particular instance of an application install. The value of this field should be a random UUID (version 4) as described in http://www.ietf.org/rfc/rfc4122.txt
Why on earth does it write a session id to cid, this way all users will count as new users?
Issue Analytics
- State:
- Created 7 years ago
- Comments:7 (4 by maintainers)
Top GitHub Comments
A fresh build is on its way to NuGet 😃 (4.1.41 should be there in ~30 minutes)
To make it less confusing i would rename
GenerateSessionId
toGenerateClientId
orGetClientId
but that would break a lot of existing applications so i guess thats out of the question.So why not just change
to
That way the programmer can set
ClientId
on their own without the framework overwriting it? Any thoughts?