Incompatible with Ember 3.9
See original GitHub issueI’m seeing some test failures in one of my addons running against ember-beta
https://travis-ci.com/alexlafroscia/ember-rx/jobs/179065658
Ultimately, this error is stemming from ember-concurrency
and (presumably) task
not being compatible with the changes that were made to the Computed Property system in Ember 3.9 to gain compatibility with decorators.
While not obvious in CI, the error that I’m seeing is actually this:
TypeError: Found non-callable @@iterator
Which stems from calling the constructor of ComputedProperty
with a function here
https://github.com/machty/ember-concurrency/blob/master/addon/-task-property.js#L419-L431
The constructor now expects an array as the first argument
The error I’m seeing is specifically triggered because of the way that first argument is “spread” here
Issue Analytics
- State:
- Created 5 years ago
- Reactions:2
- Comments:7 (2 by maintainers)
Top GitHub Comments
@basz You should ensure you don’t have a dependency that is resolving to a lower version of ember-concurrency (e.g. ember-power-select, etc.). If there’s not a more recent version of the addon that permits ember-concurrency 1.0.0, you can use Yarn resolutions to force it to resolve to ember-concurrency 1.0.0 (if you’re using Yarn).
Should be fixed in 0.9.0