question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incompatible with Ember 3.9

See original GitHub issue

I’m seeing some test failures in one of my addons running against ember-beta

https://travis-ci.com/alexlafroscia/ember-rx/jobs/179065658

Ultimately, this error is stemming from ember-concurrency and (presumably) task not being compatible with the changes that were made to the Computed Property system in Ember 3.9 to gain compatibility with decorators.

While not obvious in CI, the error that I’m seeing is actually this:

TypeError: Found non-callable @@iterator

Which stems from calling the constructor of ComputedProperty with a function here

https://github.com/machty/ember-concurrency/blob/master/addon/-task-property.js#L419-L431

The constructor now expects an array as the first argument

https://github.com/emberjs/ember.js/blob/89b122ac65824b48d7c08da7f2d8b3998041c372/packages/%40ember/-internals/metal/lib/computed.ts#L168

The error I’m seeing is specifically triggered because of the way that first argument is “spread” here

https://github.com/emberjs/ember.js/blob/89b122ac65824b48d7c08da7f2d8b3998041c372/packages/%40ember/-internals/metal/lib/computed.ts#L207

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:2
  • Comments:7 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
maxfierkecommented, Aug 7, 2019

@basz You should ensure you don’t have a dependency that is resolving to a lower version of ember-concurrency (e.g. ember-power-select, etc.). If there’s not a more recent version of the addon that permits ember-concurrency 1.0.0, you can use Yarn resolutions to force it to resolve to ember-concurrency 1.0.0 (if you’re using Yarn).

1reaction
machtycommented, Mar 7, 2019

Should be fixed in 0.9.0

Read more comments on GitHub >

github_iconTop Results From Across the Web

Incompatible with Ember 3.9 - - Bountysource
ember -concurrency is an Ember Addon that enables you to write concise, worry-free, cancelable, restartable, asynchronous tasks. See More. Top Supporters ...
Read more >
Deprecations Added in Ember 3.x
Importing deprecate from @ember/application/deprecations has been deprecated. ... To upgrade to 3.9 directly, just add this to your deprecation workflow, ...
Read more >
Ember Quickstart tutorial: Parsing error: Unexpected character ...
You're ember-source is set to ~3.9.0 . I'm pretty sure @action is an Octane feature that was added in 3.14. Either update ember-source...
Read more >
Changelog - ember-bootstrap
#1736 Upgrade Ember to 4.1, drop support for Ember < 3.24 (@simonihmig) ... which fixes incompatibility with Ember 3.1 (0d81cc3) ...
Read more >
error find-up@4.1.0: The engine "node" is incompatible with ...
[Solved]-error find-up@4.1.0: The engine "node" is incompatible with this module. Expected version ">=8". Ember js + Heroku Deployment-ember.js · score:1.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found