Command.Wait() inside BackgroundWorker.DoWork() kill the app

Hi, I try to run several Command and it works fine. the problem is i’d like to report progress in a winform using BackgroundWorker for respectful syncing on the UI thread. But the app crash without respect for any try catch at first Command.Wait() during debug.

Any idea ?

[hguy]

This solution did work for a time and it start crashing again. I give up :p There is some random weirdness i can’t comprehend in this and it’s not that necessary. Thanks for your help though.

[hguy]

After my various refacto i didn’t reproduce the crash but i finaly succeed.

This construct by doing a mix of BackgroundWorker and IProgress do work.

Inside GitAddCommitTagAndPush() i use the BindingList<> hook from previous post.

I ask IProgress to call backgroundWorker.ReportProgress() so my underlying layers are agnostic and doesn’t know System.Windows.Form.

Thank you for your help!

	/// <summary>
	/// Handler for closing the main form
	/// </summary>
	/// <param name="sender">sender object</param>
	/// <param name="e">CancelEventArgs data</param>
	private void MainFormClosing(object sender, CancelEventArgs e)
	{
		if (!_DoCloseStuffCompleted)
		{
			e.Cancel = !this.DoCloseStuff();
			if (e.Cancel) return;// Problem ? no need to go further

			if (Config.UserSettings.Default.GitBackupEnabled)
			{
				var pb = this.vaultProgressBar;
				pb.BringToFront();
				pb.Minimum =
				pb.Value = 0;
				pb.Maximum = 100;
				pb.TitleForeColor = TQColor.Purple.Color();
				pb.TitleFont = FontService.GetFont(15F, this.UIService.Scale);

				var x = (this.Size.Width / 2) - (this.vaultProgressBar.Width / 2);
				var y = (this.Size.Height / 2);
				var loc = new Point(x, y);
				pb.Location = loc;
				pb.Visible = true;

				// IProgress
				var progress = new Progress<ProgressBarMessage>((mess) =>
				{
					this.backgroundWorkerGit.ReportProgress(mess.Percent, mess);
				});

				this.backgroundWorkerGit.RunWorkerAsync(progress);
			}
			return;
		}
	}

	bool _DoCloseStuffCompleted = false;

	private void backgroundWorkerGit_DoWork(object sender, DoWorkEventArgs e)
	{
		var arg = e.Argument as Progress<ProgressBarMessage>;
		this.GameFileService.GitAddCommitTagAndPush(arg);
	}

	private void backgroundWorkerGit_ProgressChanged(object sender, ProgressChangedEventArgs e)
	{
		var pb = this.vaultProgressBar;
		var mess = e.UserState as ProgressBarMessage;
		pb.Title = mess.Title;
		pb.Value = e.ProgressPercentage;
		pb.Invalidate();
	}

	private void backgroundWorkerGit_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
	{
		var pb = this.vaultProgressBar;
		pb.Visible = false;
		pb.SendToBack();

		_DoCloseStuffCompleted = true;
		this.Close();// Close again but it will pass
	}