Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

v2.17.0 introduces a regression

See original GitHub issue

I do not use this package directly, but xo does.

After you released 2.17.0 xo doesn’t run anymore with this error:

If you break retro-compatibility, you are supposed to to a major version bump.

/builds/***/node_modules/is-my-json-valid/index.js:366
      visit(name+'['+i+']', node.items, reporter, filter, schemaPath.concat('items'))
                                                                     ^

TypeError: Cannot read property 'concat' of undefined
    at visit (/builds/***/node_modules/is-my-json-valid/index.js:366:70)
    at /build/***/node_modules/is-my-json-valid/index.js:416:9
    at Array.forEach (<anonymous>)
    at visit (/builds/***/node_modules/is-my-json-valid/index.js:409:18)
    at /builds/***/node_modules/is-my-json-valid/index.js:543:9
    at Array.forEach (<anonymous>)
    at visit (/builds/***/node_modules/is-my-json-valid/index.js:540:31)
    at compile (/builds/***/node_modules/is-my-json-valid/index.js:565:3)
    at visit (/builds/***/node_modules/is-my-json-valid/index.js:340:16)
    at /builds/***/node_modules/is-my-json-valid/index.js:416:9

Issue Analytics

State:
Created 6 years ago
Reactions:33
Comments:41 (1 by maintainers)

Top GitHub Comments

11reactions

LinusUcommented, Dec 18, 2017

Fix published as 2.17.1, so sorry for any inconvenience caused!

9reactions

LinusUcommented, Dec 18, 2017

Would like to take this opportunity to plug lock files 🔒📝

By using npm 5 or newer, or yarn, a package-lock.json (or yarn.lock) file will automatically be created when adding or removing dependencies. This file will contain the exact version of every dependency (even the dependency of your dependencies, and so forth). Whenever npm install (or yarn) is run, it will look for this file and install the exact dependencies as the last time, thus ensuring that your builds are reproducible.

The file should be commited together with the rest of the code, so that everyone that works on the project have the same versions of every dependency, and so that the CI and deploy also uses the same versions.

More reading: “Yarn determinism” blog post, package-lock.json on npm docs, yarn.lock on yarn docs

Again, sorry for any inconvenience, hopefully this wont happen again, but I would advice everyone to start using lock files to minimize the impact if (when 😄) it happens the next time. If anyone is in London I’d be happy to buy you a beer and discuss lock files and JavaScript 😄

Cheers 🍻

Top Results From Across the Web

Chapter 17: Introduction to Regression

Regression is a statistical procedure that determines the equation for the straight line that best fits a specific set of data.

Introduction to Linear Regression - Online Statistics Book

In simple linear regression, we predict scores on one variable from the scores on a second variable. The variable we are predicting is...

17 Transforming Variables in Regression - Bookdown

This is a textbook written for an Introduction to Research Methods class in ... 17 Transforming Variables in Regression ... 17.1.2 Polynomial Regressions....

Linear Regression using Stata - Princeton University

When running a regression we are making two assumptions, 1) there is a linear relationship between two variables (i.e. X and Y) and...

What is Regression Testing? Definition, Tools, Method, and ...

Regression testing is a type of testing that is done to verify that a code change in the software does not impact the...