question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

bring into node core

See original GitHub issue

At the face to face in Berlin we brought up bringing this into core and exposing it as require('stream').pump. A couple questions:

  1. are you ok with this idea?
  2. do you want to open the pull or are you ok if I or @mcollina does so?
  3. How do you feel about waving copyright on this and end-of-stream? It’s OK if you don’t want to do so but if you do it will make it significantly less complicated to bring it into node core.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:3
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

6reactions
mafintoshcommented, May 8, 2017

@calvinmetcalf also cool initiative, forgot to say that.

3reactions
mafintoshcommented, May 8, 2017
  1. Sure, as long as these modules stay backwards compat <4 without any babel stuff
  2. You should probably do it
  3. I’m okay waving copyright.
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to: Install a Lighting Node Core - Corsair
Mount your Lighting Node Core in an open area in your case using the provided double-sided tape. · Install your fans in your...
Read more >
How To Install the Lighting Node Core for CORSAIR RGB ...
The CORSAIR Lighting Node CORE gives you control over your case and fan lighting with brilliant patterns and effects.
Read more >
HOW TO Install Corsair RGB Fans with Lighting Node Core ...
A quick video on how I wired up 10 corsair QL120 fans in my Lian Li O11 XL using the lighting node core...
Read more >
HOWTO Corsair QL120 & QL140 RGB Fan + Lighting Node ...
In this video Im going to show you how to install and setup the brand ... HOWTO Corsair QL120 & QL140 RGB Fan...
Read more >
Using multiple Corsair RGB controllers to control more than 6 ...
Lighing Node Core - (comes with some fan kits, or may be in stock on corsairs site, I don't see this on amazon...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found