Devs: battlefield's countAll and other all-methods must be removed from cards

Found big problem for multiplayer games: many popular methods in Battlefield.java don’t use range settings (e.g. it’s will counts/finds too many permanent from non accessible players).

Affected methods (search by field.values()):

• countAll;
• contains (2 of 3 implementation);
• getAllPermanents;
• getAllPermanentIds;
• getAllActivePermanents;
• getPhasedIn – ok, not used in cards;
• getPhasedOut – ok, not used in cards.

Cards/abilities/effects must use only range related methods like game.getBattlefield().count(), but inner game engine must use full permanents list like game.getBattlefield().countAll().

[JayDi85]

I think it’s was about containsControlled and containsPermanent.

Usage must be researched. containsPermanent as example: it’s used to check a permanent on battlefield (is it actual/removed or not). It’s ok in that use case. But that method can be potentially buggy in searching/filtering code.

[github-actions[bot]]

Steam Vines - (Gatherer) (Scryfall) (EDHREC)

{1}{R}{R} Enchantment — Aura Enchant land When enchanted land becomes tapped, destroy it and Steam Vines deals 1 damage to that land’s controller. That player attaches Steam Vines to a land of their choice.