Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

There are several functions inside Commander.java which are empty

See original GitHub issue

Several functions have an @Override but are simply empty:

https://github.com/magefree/mage/blob/5945aaeda467b3407de4e7b13612009318bca273/Mage/src/main/java/mage/game/command/Commander.java#L128-L130

https://github.com/magefree/mage/blob/5945aaeda467b3407de4e7b13612009318bca273/Mage/src/main/java/mage/game/command/Commander.java#L168-L170

https://github.com/magefree/mage/blob/5945aaeda467b3407de4e7b13612009318bca273/Mage/src/main/java/mage/game/command/Commander.java#L272-L282

https://github.com/magefree/mage/blob/5945aaeda467b3407de4e7b13612009318bca273/Mage/src/main/java/mage/game/command/Commander.java#L322-L334

There’s no comment indication if this is intentional or not. See for example #8660 which caused issues with Changeling commanders.

Issue Analytics

State:
Created 2 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

1reaction

awjacksoncommented, Mar 12, 2022

At least some of these MageObject interface methods (e.g. adjustCosts, adjustTargets) are relics that shouldn’t exist at all anymore–they were refactored some time ago into the CostAdjuster and TargetAdjuster classes. I’ll look at cleaning them up after the next release.

0reactions

Alex-Vasilecommented, Mar 12, 2022

Were there comments added for why the above functions should be empty?

For example, why does setStartingLoyalty do nothing versus calling SourceObject.setStartingLoyalty(startingLoyalty)?

Same for all of the others.

Top Results From Across the Web

c# - Multiple Main Functions - Stack Overflow

Just for clarification, a class can have more than one main method. For example, you could have public static void main() and public...

Stack empty() Method in Java - GeeksforGeeks

empty () method in Java is used to check whether a stack is empty or not. The method is of boolean type and...

5 ways to force Java garbage collection - TheServerSide.com

If developers need the JVM to free up some heap space, here are five ways to motivate and then force garbage collection in...

public static void main(String[] args) - Java main method

The main method can contain code to execute or call other methods, and it can be placed in any class that's part of...

Lesson: A Closer Look at the "Hello World!" Application

*/ class HelloWorldApp { public static void main(String[] args) { System.out.println("Hello World!"); //Display the string. } } In the Java programming language ...