Remove Tone.js from JavaScript package?

The package at https://cdn.jsdelivr.net/npm/@magenta/music@0.0.5/dist/magentamusic.min.js now includes Tone.js as well, as the player using it is exported from core.ts.

I don’t think this is something users would expect, and may cause issues with projects using other versions of Tone.

[tambien]

Haven’t done a ton of research into this, but shouldn’t tree-shaking remove the need for splitting apart @magenta/music into multiple packages?

In an ideal world import { Coconet } from @magneta/music would only pull in just the model and it’s dependency files, so if that model didn’t rely on anything with Web Audio / Tone.js, then it wouldn’t be compiled into your code. In practice i’ve found that you’ve got to deep require Coconet by doing something like import {Coconet} from @magenta/music/es5/coconet/Model.

Reading a little about tree-shaking with typescript just now, seems like maybe setting the tsconfig to export an esnext module with import/export statements instead of all require statements would enable tree-shaking in compilers that support it (like webpack).

I haven’t tested this out myself, just wondering if this might be a simpler direction that is better setup for future browser/ES6 developments vs reorganizing the codebase into multiple packages.

[mattetti]

@teropa I agree, and ideally we could provide some sort of interface/adapters so one can bring their own player/lower level audio implementation.