Refactor `Magento_BundleConfig` module to follow best-practices

This issue is a:

• Bug
• Feature suggestion
• Documentation issue
• Other (Code Quality task)

Environment

Question	Answer
Magento version	N/A
Browser + version	N/A
node.js version (node -v)	N/A
npm version (npm -v)	N/A

Description

The Magento_BundleConfig module was authored by me. I barely know PHP, and I certainly don’t know best-practices for m2 modules. The majority of this code is copy/pasted from Magento_RequireJs in core.

Expected result:

Magento_BundleConfig is refactored to follow Magento module best-practices.

Possible solutions:

[Vinai]

@DrewML Thanks for the great response, you explained it much clearer than I could have done that.

Also thank you regarding your comments on defer. It would probably be the right choice, but interestingly async is working well for us currently. Still probably will change that when I get a chance to work on the project again and refactor.

defer is currently not added by Magento_BundleConfig because there is at least 1 script in a default m2 installation in the body that expects certain modules to be available synchronously.

True, so far I added a path config to a patched version that wraps it in a define().

[aligent-lturner]

I’ll just piggy-back onto this existing issue, since the things I’ve noticed probably fall under refactoring:

1. Folder structure needs to be of the form <Vendor>/<Module>, so should be Magento/BundleConfig, rather than just Magento_BundleConfig.
2. etc/module.xml requires the module tag to have a setup_version attribute (in the form x.x.x) - without this, bin/magento commands fail (as it reads module information each time). You can use whatever numbering scheme you want (e.g. <module name="Magento_BundleConfig" setup_version="0.1.0">)