Tracking of customer account pages not working
See original GitHub issueThis issue is a:
- Bug
- Feature suggestion
- Documentation issue
- Other (Please Specify)
Environment
Question | Answer |
---|---|
Magento version | 2.3.0 |
Browser + version | N/A |
node.js version (node -v ) |
N/A |
npm version (npm -v ) |
N/A |
Description
When clicking around in “Record” mode for the RequireJS Bundle Config generator, results are not captured for customer account pages (reported by @davidverholen).
This is very likely the result of a heuristic that is not 100% correct, and we do not surface that error anywhere in the UI.
Expected result:
The fix for this should be to extend _getPageConfigType
in interop.ts
to have a more reliable heuristic.
Note: A hard requirement of fixing this will be that it does not require installing any additional modules. One of the goals of the Bundle Generator is to be able to generate config with 0 changes to the Magento store.
Possible solutions:
We can add in some additional heuristics for pages that don’t match the pattern being looked for in _getPageConfigType
. An example would be a hardcoded list of pages that we can’t find the layout handle for, and some additional checks to figure them out.
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (9 by maintainers)
Top GitHub Comments
I’m working on a prototype that may solve this problem in a bit of a different way, but would yield more control over to developers. Will share when I have more details
(Haven’t forgotten about this, just bogged down with some other work atm. Will get back into this one soon)