question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement module name validation in 'Create a plugin' and 'New module' dialog

See original GitHub issue

Describe the bug

To implement module existence validation for the field Target Module in the following scenarios

  • Create a plugin dialog
  • Create an observer dialog
  • New module dialog

This was implemented in the old way and removed as part of https://github.com/magento/magento2-phpstorm-plugin/pull/324 and https://github.com/magento/magento2-phpstorm-plugin/pull/318, respectively, as its not directly possible using annotations. More info at https://github.com/magento/magento2-phpstorm-plugin/pull/324#discussion_r509635113.

Expected behavior

Target module field is validated using the list of indexed modules in the Magento 2 project

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
drpayynecommented, Oct 23, 2020

I understand @VitaliyBoyko, thanks. In that case, would it be better to create a new rule to validate target module fields? It would implement same logic of getting list of modules in current project and checking the existence of the value in the module list, but inside a rule so that annotations can be used and it can be reused.

0reactions
drpayynecommented, Oct 28, 2020
Read more comments on GitHub >

github_iconTop Results From Across the Web

Change the validation of the Argument Name field in ... - GitHub
Describe the bug. Currently, we can't use an underscore _ in the argument name, only letters and numbers. The underscore character is not ......
Read more >
Use the Plug-in Manager in Logic Pro - Apple Support
In Logic Pro, use the Plug-in Manager window to validate, organize, and manage installed plug-ins.
Read more >
Plugin Development - Gerrit Code Review
Plugins that use explicit Guice registration must name the Guice modules in the manifest. Up to three modules can be named in the...
Read more >
Defining Constraints (Validations) on Entities and/or Fields.
The next step is to create the class that will validate the constraint. The constraint validation will go in the namespace Drupal\[MODULENAME]\ ...
Read more >
Displaying content in a dialog in JIRA - Atlassian Developer
Open a command window and go to the plugin root folder (where the pom. · Run atlas-create-jira-plugin-module . · Supply the following information ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found