Algorand Extension Cannot Sign an ASA Opt-in Transaction

✅ Prerequisites

• ✅ Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
• ✅ Are you running the latest SDK version?
• [] Are you reporting to the correct repository (magic-sdk)? No, the algorand extension code is closed source.

🐛 Description

If I am not mistaken the Magic Extension cannot sign an Algorand ASA opt-in transaction. This would be a major bug in the Algorand Extension as it would imply that users cannot receive ASA tokens (Algorand’s ERC20 equivalent).

🧩 Steps to Reproduce

1. Clone this repo
2. Add a test email in index.ts
3. npm install && npm run dev
4. Click on “Login With Magic!” => Wait until the address displays, I did not add a loader.
5. Try signing an opt in Tx with a mock account
6. Try signing an opt in Tx with Magic => Crashes

🤔 Expected behavior

My users should be able to opt-in to ASA tokens, a prerequisite to any airdrop.

😮 Actual behavior

I get the following error: Uncaught (in promise) Error: Magic RPC Error: [-32603] Internal error: address seems to be malformed

💻 Code Sample

Repro repo here

🌎 Environment

Software	Version(s)
@magic-ext/algorand	0.2.0
algosdk	1.12.0
magic-sdk	6.2.1
npm	7.24.0
Browser	Firefox (95.0b11) & Brave(1.32.106)
Operating System	Mac OS Big Sur & Monterey

[hcote]

@fmonper1 @Standaa this should be fixed now. Once you create the Transaction object with algosdk.make...TxnWithSuggestedParams() just encode the object and pass it to magic.algorand.signTransaction(encodedTxn).

Here’s a codesandbox - codesandbox.io/s/recursing-frost-lx5qgx

const sendTransaction = async () => {
    let params = await algodClient.getTransactionParams().do();
    const enc = new TextEncoder();
    let note = enc.encode("Hello World");
    let txn = algosdk.makePaymentTxnWithSuggestedParams(
      publicAddress,
      destinationAddress,
      parseInt(sendAmount),
      undefined,
      note,
      params
    );

    let encodedTxn = algosdk.encodeObj(txn.get_obj_for_encoding());
    let signedTx = await magic.algorand.signTransaction(encodedTxn);
    let receipt = await algodClient.sendRawTransaction(signedTx).do();
    console.log(receipt);
}

[Standaa]

@fmonper1 Ended up dropping Magic altogether. Production feedback from friends + Lack of team responsiveness + the extensions being closed-source + the lacklustre node APIs were way too many redflags.