question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Leaking secret through Password validation message

See original GitHub issue

Today I realized that when you use Password question and supply invalid value, the entered value is prompted in plaintext in the error message.

I believe that this should not be the correct behavior as it could resolve in accidental leaking the secret to the surrounding (in a sense, somebody watching over my shoulder).

I would inspire regarding how to approach this from well-established utilities like sudo, which does not even print any chars to prevent from leaking the length of the secret.

I could do PR to fix this.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
magmaxcommented, Aug 8, 2018

not printing any character is a bad idea, because some users think that they wrote nothing. But Inquirer is here to try to think in any option, so setting an empty character should be allowed.

I will take a look on this issue.

Thank you for reporting!

0reactions
AuHaucommented, Mar 5, 2019

Fixed with #53.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Leaking User secrets (Encrypted password and verification ...
Found a bug Details about the bug: The PUT /api/account route leaks the user's encrypted password & validation tokens to the user.
Read more >
Secret Detection - GitLab Docs
Select the Validate tab, then select Validate pipeline. The message Simulation completed successfully indicates the file is valid. Select the Edit tab. Optional ......
Read more >
Authentication - OWASP Cheat Sheet Series
Where possible, the user-supplied password should be compared to the stored password hash using a secure password comparison function provided by the language ......
Read more >
Authentication Security: Password Reset Best Practices and ...
We'll go through each of them, identify possible security breaches ... Authentication is a process to validate a user on his/her identity ...
Read more >
On my website's account creation form, how to avoid leaking ...
On the page, display a message like "An email has been sent to your address in order to verify your account or reset...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found