Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Brush Naming Conventions
See original GitHub issueIs your feature request related to a problem? Please describe.
Similar to #3584, the Background and Foreground properties for a number of controls are set to MahApps.Brushes.White and MahApps.Brushes.Black, respectively. As a user, I do not find this to be very intuitive (I expect them to stay white or black, not change depending on the theme).
Describe the solution you’d like
I suggest eliminating replacing the White and Black brushes with the following:
- White:
MahApps.Brushes.Window.Background - Black:
MahApps.Brushes.Window.Foreground
I would also think that even eliminating the Foreground brush would be ok, as this is usually set by another brush entirely (e.g. MahApps.Brushes.Accent, MahApps.Brushes.Text, or MahApps.Brushes.Label.Text).
Related
Why is there a separate Brush specifically for Label controls? Typically, all foreground colors are the same. If we were to have an alternate Brush for different kinds of text (to give users some flexibility), I’d suggest
MahApps.Brushes.Text.PrimaryMahApps.Brushes.Text.Secondary
We could even go down the Bootstrap methodology and provide a number of preset, overidable brushes (Bootstrap color documentation here):
MahApps.Brushes.Text.PrimaryMahApps.Brushes.Text.SecondaryMahApps.Brushes.Text.SuccessMahApps.Brushes.Text.DangerMahApps.Brushes.Text.WarningMahApps.Brushes.Text.InfoMahApps.Brushes.Text.LightMahApps.Brushes.Text.DarkMahApps.Brushes.Text.BodyMahApps.Brushes.Text.MutedMahApps.Brushes.Text.WhiteMahApps.Brushes.Text.Black
We could then provide the same Brushes for background use:
MahApps.Brushes.Background.PrimaryMahApps.Brushes.Background.SecondaryMahApps.Brushes.Background.SuccessMahApps.Brushes.Background.DangerMahApps.Brushes.Background.WarningMahApps.Brushes.Background.InfoMahApps.Brushes.Background.LightMahApps.Brushes.Background.DarkMahApps.Brushes.Background.WhiteMahApps.Brushes.Background.BlackMahApps.Brushes.Background.Transparent
Additional context https://getbootstrap.com/docs/4.3/utilities/colors/
Closed Issues
N/A
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:9 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@amkuchta
I‘m working on it
If I have a look to this, there are many Brushes that use the same Color. And with
MahApps.Brushes.BlackandMahApps.Brushes.WhiteI am also with you @amkuchta , that this is a bit confiusing if you are new to the MahApps Theme.Maybe we should take the chance to reduce the amount of Brushes to a handful amount, with the option for the user to select another Brush in the Style of the control. But that would lead to a complete rewrite of all the Styles we have so far.
@ all: Let’s vote for this idea either with 👍 or 👎 @punker76 If you are with us, I would be happy to help with the rewriting of the Styles.
Happy coding, Tim