Shared MD authorisation request not rejected if MD doesn't exist

When sending an authorisation request for shared MD, there is no response if the targeted MD doesn’t exist on the network.

Also, when clicking the x button in an authorisation popup a “rejected” auth response is sent back to the app instead of just ignoring it and not send any response at all:

[mrcnski]

Hey @hunterlester, I’ve investigated this and so far found nothing out of the ordinary that would be causing any issues.

So does that mean a ptr::null() is expected? Even if so, I’d then expect to log a null pointer and not simply a null value.

It’s valid, and it’s the same thing I see in our Rust-side share_mdata tests where an error is expected.

The second argument of the callback call is an FffiResult, which I observe in the browser’s authenticator to log what looks like a pointer whose referenced values have been freed from memory.

This is the only part that worries me. You should be able to reference the FfiResult here to get the error information – it’s what we do in our Rust tests. Can you confirm that this is not an issue of garbage collection in the browser or something along those lines?

I don’t see anything weird on the Rust side and we handle this error the same way as we do everywhere else. It’s possible that our current error handling is incorrect and you’ve discovered a case where the FfiResult value is dropped when it shouldn’t be.

[safesurfer]

QA verified, ref: https://github.com/maidsafe/safe_browser/pull/554#issuecomment-470449730