Mailgun 3.4.0 APIResponse failing tsc

Overview

The commit Fix merge problem. Fix eslint errors. causes an error during Typescript compilation. The APIResponse needs to be exported to allow methods in domains.ts to use it in type hints (implicilty).

The Error

lib/domains.ts:126:3 - error TS4053: Return type of public method from exported class has or is using name 'APIResponse' from external module "C:/Users/ruane/OneDrive/dev/mailgun-js/lib/request" but cannot be named.

126   assignIp(domain: string, ip: string) {
      ~~~~~~~~

lib/domains.ts:130:3 - error TS4053: Return type of public method from exported class has or is using name 'APIResponse' from external module "C:/Users/ruane/OneDrive/dev/mailgun-js/lib/request" but cannot be named.

130   deleteIp(domain: string, ip: string) {
      ~~~~~~~~

lib/domains.ts:134:3 - error TS4053: Return type of public method from exported class has or is using name 'APIResponse' from external module "C:/Users/ruane/OneDrive/dev/mailgun-js/lib/request" but cannot be named.

134   linkIpPool(domain: string, pool_id: string) {
      ~~~~~~~~~~

lib/domains.ts:138:3 - error TS4053: Return type of public method from exported class has or is using name 'APIResponse' from external module "C:/Users/ruane/OneDrive/dev/mailgun-js/lib/request" but cannot be named.

138   unlinkIpPoll(domain: string, pool_id: string, ip: string) {
      ~~~~~~~~~~~~

What’s causing the issue?

interface APIResponse {
  status: number;
  body: any;
}

How to fix the issue:

export interface APIResponse {
  status: number;
  body: any;
}

Steps to reproduce:

1. Check out 3.4.0 or master.
2. Run npm install
3. Run tsc

Workaround for those using mailgun.js as dependency:

Downgrade to Mailgun.js 3.3.2

[Vaakmeister]

Seems like the issues were resolved. Thank you.

[olexandr-mazepa]

@Vaakmeister I fixed the import in v3.5.1. Hope I resolved all compiling errors if not please let me know.