data-test selectors are not stripped from colocated component templates

I noticed that not all data-test-* selectors are being stripped from my production build. It seems that the commonality among those that remain is that the selectors that remain are all from component templates that are using the new colocated component file structure (i.e. having the component.hbs file inside the app/component directory alongside the corresponding component.js file.

[rwjblue]

ZOMG, I spent a while debugging this 😭, and have a fix. Basically, what is happen (in order) is:

1. ember-cli-htmlbars’s included hook runs, and does: 1a. gather all AST plugins registered as htmlbars-ast-plugin in the registry 1b. add babel-plugin-htmlbars-inline-precompile to the babel configuration
2. ember-test-selectors’s included hook runs, and registers a new htmlbars-ast-plugin

Specifically, the babel config is already locked down before ember-test-selectors. I do not think this issue is related to colocation at all (I doubt this ever ran against inline compiled templates), but the fact that colocation happens to desugar into using inline templates (e.g. hbs) makes it much more common to care.

The simplest fix, is to ensure that ember-test-selectors runs before ember-cli-htmlbars, and I’ve confirmed that works when manually tweaked into void-mAlex/test-selector-repro. See https://github.com/simplabs/ember-test-selectors/pull/521.

[Turbo87]

not from my side. I think it’s a bug in the build pipeline somewhere, but not related to the implementation here.