question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incoming private API breakage

See original GitHub issue

Accessing anything on a ComputedProperty instance is private API and is likely to break in the future (possibly the very soon future). This addon is accessing isDescriptor:

https://github.com/simplabs/ember-test-selectors/blob/master/addon/utils/bind-data-test-attributes.js#L30

The tl;dr is that everybody wants to make Ember.get optional and just use real ES5 getters for computed properties. As soon as we do that, component.attributeBindings will stop giving you a ComputedProperty instance with an isDescriptor, and would always return the value directly, even when it is implemented as computed property.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Turbo87commented, Dec 14, 2017

guess I’ll wait until this code actually breaks in canary and then we’ll see how to fix/work around it

0reactions
ef4commented, Feb 22, 2018

It will only break if you happen to have attributesBindings as a computed property. It’s not a common thing to do.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Connect to a private API Gateway over a Direct ... - AWS
Leaving this setting enabled breaks all access to public API Gateway APIs in the deployed Amazon VPC if the VPC uses the Amazon...
Read more >
Tutorial: Reverse Engineering a Private API - Toptal
This article shows us how to reverse-engineer a private API and find out more ... software reverse engineering techniques to break into Couchsurfing.com....
Read more >
Common API mistakes and how to avoid them - LogRocket Blog
One of the worst things we can do to an API is to release a backwards-breaking change. As a rule of thumb, adding...
Read more >
Amazon API Gateway - Failover for Private API
This exercise shows the steps to set up your private APIs in more than one AWS Region using an active-passive disaster recovery strategy....
Read more >
How a RESTful API server reacts to requests - O'Reilly
Learn how to properly design RESTful APIs communication with clients ... how the server should react to incoming requests with status codes.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found