Declaring a manager with a custom queryset does not work.

When following the SafeDelete documentation, it seems declaring a manager with a custom queryset should be done like this: objects = SafeDeleteManager(MyCustomQuerySet)

Following this:

• The manager works as expected
• But the methods of my custom queryset are not visible! I got errors like: AttributeError: 'SafeDeleteManager' object has no attribute 'my_custom_method_from_my_custom_queryset' when I try to access it.

I found a workaround using from_queryset method with safedelete? objects = SafeDeleteManager.from_queryset(MyCustomQuerySet)()

This way, everything seems to work, but I’m worry I’m missing something. Could you please tell me if I did something wrong with the official method? Otherwise, the documentation should be updated.

Note : I’m using Django 1.11 Thanks a lot for this very useful lib by the way.

[Gagaro]

You are overriding the get_safedelete method which set the _safedelete_visibility attribute. See https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/managers.py#L57-L62.

Set _queryset_class on your manager to MyQuerySet and remove your get_queryset method.

[Gagaro]

I think your solution should be the correct one. I see that we overwrite _queryset_class in our __init__ method, but it is always better to keep the same api as Django.

I don’t remember why it was done that way, we should try to remove the __init__ method and change the documentation accordingly if this works as intended.

Thanks for the report 👍 .