Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

data-josh-anim-delay doesn't work

See original GitHub issue

Hi,

The data attribute data-josh-anim-delay doesn’t work because:

delay = targetElm.dataset.joshDelay; // Animation delay

in josh.js

should be

delay = targetElm.dataset.joshAnimDelay; // Animation delay

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:5 (1 by maintainers)

Top GitHub Comments

4reactions

bueprocommented, Oct 1, 2020

Alternatively the data attribute name could be changed to data-josh-delay. In this context I am wondering if the josh-anim name space is needed at all or would just josh be easier hence data-josh-anim-name could become josh-name or just josh. See as well michalsnik/aos.

0reactions

bueprocommented, Mar 28, 2022

@mamunhpath thank you for your library and the update. Since I am using it in a cms where all the js files get concatenated the compressed version from the file src/josh.js is needed. When bumbing the library to 1.0.8 two issues were found:

It was confusing to me that dist/josh.min.js isn’t the compressed version since the naming convention would suggest so.
When embedding dist/josh.es5.min.js the attribute data-josh-anim-delay isn’t working where data-josh-delay does.