Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Get rid of the Element class

See original GitHub issue

The Element class is just used for testing. By using Element we are not testing the actual code. Also, every time we implement a new feature for the Feature class, we need to implement it for Element as well. I think it would be a better idea to use real classes for testing and get rid of Element. We could start by substituing it by number, which should be straighforward. Although I think it could be a good idea to add some more tests for the different Feature classes.

Related to https://github.com/fireeye/capa/issues/5, as it symplifies the implementation.

@mr-tz @williballenthin what do you think?

Issue Analytics

State:
Created 3 years ago
Comments:6 (1 by maintainers)

Top GitHub Comments

1reaction

williballenthincommented, Jun 24, 2020

if you want to remove element and use another simple feature, like Number, in its place, that’s fine with me, too.

1reaction

mr-tzcommented, Jun 24, 2020

I think it can be removed and we can replace the tests. Unless @williballenthin had something different in mind for it?!

Top Results From Across the Web

How To Remove a Class Name

Learn how to remove a class name from an element with JavaScript. Remove Class. Click the button to remove a class from me!...

Removing elements by class name? - javascript

Get container element by ID. Get needed child elements by tag name. Iterate over children, test for matching className property. elements[i].

Remove all elements with specific Class using JavaScript

To remove all elements with a specific class, use the `document.querySelectorAll()` method to select the elements by class. Use the `forEach()` method to ......

How to remove a class name from an element through ...

JavaScript can be used to remove a class name from an HTML element on a webpage with the help of the .classList.remove(). It...

How to Remove All Classes From an Element With ...

To remove all classes from an element in JavaScript, set the className property of the element to an empty string ( '' ),...