code in readme.md cause cyclical redirct

If you don’t want to display a login form that tells the user that they are redirected to the identity server, you can use the convenience function this.oauthService.loadDiscoveryDocumentAndLogin(); instead of this.oauthService.loadDiscoveryDocumentAndTryLogin(); when setting up the library.

This directly redirects the user to the identity server if there are no valid tokens.

after use this.oauthService.loadDiscoveryDocumentAndLogin() , the app into an infinity redirct circulation

[jonyeezs]

@jeroenheijmans is right.

I think what threw us off was the method name “...Login()”. We assumed it was checking to see if we were authenticated, if not send us to the login page.

But all it did was to check if the request had the correct hash fragments to obtain the access key.

Steps we took that works:

1. use loadDiscoveryDocumentAndLogin for the page that would be redirected from the login screen as well as loading the app.
2. Use the boolean result of the above method to begin init initImplicitFlow to send user to login page otherwise begin the app.

[jonyeezs]

Would love to put a PR in. And get that for hacktoberfest heh

On Tue, 8 Oct 2019, 12:38 am Jeroen Heijmans, [e-mail] wrote:

Good to hear you’ve found a solution. Shall we close this one then? Or will you suggest a PR with a change to readme to clarify things further? Either’s good to me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/manfredsteyer/angular-oauth2-oidc/issues/639?email_source=notifications&email_token=ACS4BBS7GNQMJESAR4Y3ON3QNNCWHA5CNFSM4I3C6BR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQSPOA#issuecomment-539043768, or mute the thread https://github.com/notifications/unsubscribe-auth/ACS4BBVF2K7VIMGSVAQCT2TQNNCWHANCNFSM4I3C6BRQ .