question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve behavior when setupAutomaticSilentRefresh is called *after* loadDiscoveryDocument methods

See original GitHub issue

In #722 we uncovered that calling setupAutomaticSilentRefresh() after e.g. loadDiscoveryDocumentAndTryLogin() can cause weird behaviors down the line. See the linked issue for those situations.

This issue proposes we improve this by either:

  • at worst throwing a more descriptive error to explain that the order of methods called is unexpected (instead of some random other error down the line)
  • at best “just work” with some sensible behavior

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
aznarepsecommented, Mar 22, 2020

Hi, yes, I will have some time this next weeks. Sadly, this corona-virus crisis is bringing me to stand-down on some projects I had on the keyboard. I will also be likely able to provide a simple app which ‘bangs’ all the time with this behaviour.

1reaction
jeroenheijmanscommented, Feb 23, 2020

Wow! That’s a… thorough analysis 😅. I’m not sure if I’ll personally have time on the short term to think/debug along, but maybe some other community member does?

On a side note, at this time it’s sad there’s no good test coverage. Would’ve been good to verify your assumptions with (marble) tests.

Read more comments on GitHub >

github_iconTop Results From Across the Web

angular-oauth2-oidc - Bountysource
We use this library in our angular 12 project with azure ad b2c and code flow. After the login we get an access-token...
Read more >
angular - Query parameters (code, state) not removed after login
This issue only appears with chrome, I fixed it in Firefox by doing a location.hash = ''; in the login sequence method, even...
Read more >
Silent Refresh - angular-oauth2-oidc
This is a well-known solution that compensates the fact that implicit flow does not allow for issuing a refresh token. It uses a...
Read more >
Build an Ionic App with User Authentication | Okta Developer
For an updated version of this blog post, see Ionic + Sign in with ... add a logout() method, as well as methods...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found