Silent refresh causes unnecessary change detect

Describe the bug When you have other parts of the application having iframes that are sending messages back to the parent window, silent refresh’s event listener on message is causing angular to trigger its change detection.

Stackblitz example I can help setup if someone could point me to a seed stackblitz

To Reproduce Steps to reproduce the behavior:

1. Setup silent refresh
2. Add something triggering window message event
3. add a ngDoCheck to any component or directive with a console.log
4. watch it light up.

Expected behavior Should not have unnecessary change detect due to using silent refresh

Desktop (please complete the following information):

• OS: Windows
• Browser Chrome
• Version ^5.0.2

Additional context I reckon this should fix it; but then again I’m not sure if there’s any where else down the stream you’d need to run inside angular again.

this.ngZone.runOutsideAngular(() => {
    window.addEventListener('message', this.silentRefreshPostMessageEventListener);
});

[jeroenheijmans]

Your remarks make sense to me. All that’s needed probably is for the maintainer to include the fix, or indicate that a PR for this is welcome. I know work on this library is typically done only every few months, and a couple at once then usually.

[zampage]

@kailo777 I’m aware that the same problem exists in other tools like Redux Dev Tools. We use the NgxsReduxDevToolsPlugin for NGXS, where we also opened an issue https://github.com/ngxs/store/issues/1758

But the problem also exists if we remove the Redux Dev Tools. As the author of this issue already stated, this problem comes from message eventlistener not running outside of angular zone. And there are apparently multiple packages that rely on the message events, hence generating the same problem.