/token is not being called sometimes

I have an angular8 application using the Autherization_code work flow here is my auth service

export class AuthService {
  constructor(private oauthService : OAuthService, configurationService: SherpaConfigurationService, private securitiesService: SecuritiesService) { 
    this.oauthService.configure(authConfig);
    this.oauthService.tokenValidationHandler = new JwksValidationHandler();
    this.oauthService.loadDiscoveryDocumentAndLogin();
  }
  login()
  {
    this.oauthService.initCodeFlow();
  }

I have a guard setup basically to check and see if I have an access token in my sessionStorage. If not then call the login() method

export class AuthGuardService implements CanActivate{
  constructor(public router: Router, private authService : AuthService) {}
  canActivate(): boolean {

    if (!sessionStorage.getItem('access_token')) {
      this.authService.login();
      return false;
    }
    return true;
  }
}

I see the /Authorize going out. I get back the code in the redirect_URL then I see /key call going out. But for some reason sometimes I see /token call being made which I get the Access token in return. but most of the time the /token doesn’t get called which result me keep redirecting to the url and my sessionStorage doesn’t get populated with the access_token. What am I doing wrong?

[jelbatnigi]

I am sorry if I offended you by saying too complicated. I do really appreciate your help! please don’t get me wrong It is a great solution maybe the reason I find it hard is because I am a beginner to Angular. But I think there must be an easier way to handle this. the few examples that I have seen people using this library didn’t have this problem. If using Async workflow is needed for this library to work properly then this should be documented and addressed, or there should be a built in way to handle this race condition scenario.

[jeroenheijmans]

No offense taken!

I personally don’t see how most real-world applications using OAuth/OpenID can usefully spin up without doing some async work. But others may have good production-ready examples for that? I think the sample in this repo itself contains some synch logic in the guards.

For me, my sample repo serves as documentation to a degree. It is also linked from the readme, I believe. But, all this stuff is highly dependent on how you mean to write your application, so generic guidance would be really hard.

Good luck!