Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

-w flag enabled by default

See original GitHub issue

I just noticed an issue with the CLI arguments, and more particular concerning the -w (write_to_movie) flag. It appears that when -s (save_last_frame) is False (most of the time, I think), write_to_movie is set True even though -w hasn’t been placed. (that’s why for example in the README just -pl is used instead of -plw).

That is shown at l. 166 of config.py: "write_to_movie": args.write_to_movie or not args.save_last_frame,

This may cause issues when one wants to get the last frame AND the video.

Should we fix it or let -w enabled by default (even though it’s not very rigorous) ?

Issue Analytics

State:
Created 3 years ago
Comments:14 (14 by maintainers)

Top GitHub Comments

1reaction

leotrscommented, May 21, 2020

How about this:

video only: -w OR nothing
last frame only: -s
both: -ws
neither: -d (for “dry run”, or any other available letter)

0reactions

leotrscommented, May 22, 2020

@huguesdevimeux if it is ready for merging, then go ahead. We can always add tests later*.

Famous last words.

Top Results From Across the Web

Runtime Enabled Features

Features that are hidden behind a runtime flag are known as Runtime Enabled Features. It is a requirement of the Blink Launch Process...

Warning Options (Using the GNU Compiler Collection (GCC))

The warning is emitted only with --coverage enabled. By default, this warning is enabled and is treated as an error. -Wno-coverage-invalid-line-number can be ......

verbose` flag be enabled by default in magit commit screen?

The magit workflow seems to always be open status buffer and then open split with commit buffer, you always end up with two...

Enable and disable GitLab features deployed behind feature ...

The feature becomes enabled by default. The feature flag is removed. These features can be enabled and disabled to allow or prevent users...

What are Chrome flags?

Chrome flags enable the user to activate or deactivate experimental features, whereas the controls available from the chrome://settings page ...