Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

links to issues lose the anchor portion of the href

See original GitHub issue

If I visit my notifications page and see that I have a notification linking to a specific comment on a PR, it will have a url like https://github.com/owner/repo/pull/123#issuecomment-456, with #issuecomment-456 being the anchor pointing to the specific comment. However, clicking on this notification in Gitify will open a browser tab to https://github.com/owner/repo/pull/123, missing the anchor pointing to the comment.

Issue Analytics

State:
Created 7 years ago
Reactions:10
Comments:6 (2 by maintainers)

Top GitHub Comments

3reactions

manosimcommented, Sep 22, 2016

@lgeiger That would make sense but unfortunately it’s still a url to the api (not an html_url) so have to check all types of notifications and see whether they are returning this field etc. Will investigate further - it is a nice idea!

@frapontillo That is exactly what we need - I had a look on the GraphQL API and it looks promising but it is currently missing notifications. Was informed that they GitHub team is planning to include notifications at some point so fingers crossed!

2reactions

manosimcommented, Jun 7, 2016

That would be great but it is not possible with the current Github API. Currently to achieve that we will have to make another request for each notification (if there are 50 notifications - that means 50 more requests). The reason this doesn’t work one is here. I’ve just sent an email to GitHub regarding adding an html_url field for the subject of each notification. Fingers crossed!