Integration tests breaks for components that inject notifications
See original GitHub issueHello !
After upgrading a project from ember 2.11 to 2.13, I noticed that all the integration tests of the components that injects ember-cli-notifications are breaking : Assertion Failed: Attempting to inject an unknown injection: 'service:notification-messages'
.
In these components, I inject your addon “individually” via :
notifications: Ember.inject.service('notification-messages'),
.
I also tried to inject via an initializer afterward, and tests are ok with that method. The problem is I don’t need to inject it everywhere, so I shouldn’t use an initializer in my project…
I made a small repo that replicate this problem : https://github.com/Edralo/notification-test-fail
I haven’t looked much to find where the problem is, but maybe it’s linked to https://github.com/emberjs/rfcs/blob/master/text/0150-factory-for.md since the problem appeared with ember 2.12.
That’s pretty much all i know about the issue for now, sorry
Issue Analytics
- State:
- Created 6 years ago
- Reactions:6
- Comments:13 (3 by maintainers)
Top GitHub Comments
I was able to clear up the integration test issues with the same approach:
This has changed with the release of https://github.com/mansona/ember-cli-notifications/pull/251 and shouldn’t be an issue anymore 👍 let me know if you have any questions or are still having problems