nested packed enums not handled properly

I’m trying to read a pbf with a packed repeated enum field (as defined here. The compiled pbf parser seems odd for that field:

Relation.read = function (pbf, end) {
    return pbf.readFields(Relation._readField, {id: 0, keys: [], vals: [], info: null, roles_sid: [], memids: [], types: 0}, end);
};
Relation._readField = function (tag, obj, pbf) {
    […]
    else if (tag === 10) obj.types.push(pbf.readVarint());
};

Shouldn’t the default value for the types field be an empty array [] (instead of 0), and the data be read via something like pbf.readPackedVarint(obj.types); (instead of obj.types.push(pbf.readVarint());)?

[kjvalencik]

The issue is here. https://github.com/mapbox/pbf/blob/master/compile.js#L270 That line should be

if (enumValues && !field.repeated)

I have a fix and test on a fork that I forgot about. I’ll submit a PR tomorrow.

[mourner]

Released as 3.0.4.