question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug: keydown:Enter is blocked by imagelightbox

See original GitHub issue

imagelightbox blocks the use of the Enter button.

How to reproduce

  1. Go to https://rejas.github.io/imagelightbox/ with your browser
  2. Open the developer tools [F12]
  3. Manipulate the DOM with creating a textarea tag after the container div, see the example below
  4. Click inside the new textarea to focus it
  5. Try to create a line break by using the Enter key on your keyboard.

Code example: bildschirmfoto vom 2017-09-24 17-08-30

It should look like this imagelightbox

What I expect

The Enter key should create a line break.

What happens instead?

The Enter key creates no line break.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:11 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
rejascommented, Sep 24, 2017

First: Best bug report I’ve seen in my life, well done! Second: Confirmed, introduced via commit 36de2f0bcd1b7e904b26f8dbccc79577404608b6 in https://github.com/rejas/imagelightbox/pull/118 Third: Maybe @paxperscientiam can say for what that culprit line 559 is needed?

0reactions
rejascommented, Oct 11, 2017

Released v0.8.0, hope it helps 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

rejas/imagelightbox release history - changelogs.md
Fixed #201, a bug with videos not being preloaded if they were added to an already ... Fixed #133 keydown:Enter is blocked by...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found