Wait doesn't seem to work

I have the below code which has a Wait call().

When I call start I’d expect that to block until the Wait delegate had succeeded but this isn’t the case. Despite this if I put a breakpoint on the delegate it never gets hit. Any ideas? Thanks

        protected override Task OnStart(CancellationToken cancellationToken)
        {
            try
            {
                this.Logger.LogInformation("Starting MS SQL Server container. This may take a few minutes if the image is not in local cache.");

                this.containerService = new Builder()
                    .UseContainer()
                    .WithName("profiles-sql-server")
                    .UseImage("mcr.microsoft.com/mssql/server:2017-latest-ubuntu")
                    .WithEnvironment("ACCEPT_EULA=Y", $"SA_PASSWORD={SAPassword}", "MSSQL_MEMORY_LIMIT_MB=4000")
                    .ReuseIfExists()
                    .ExposePort(21433, 1433)
                    //.WaitForPort("1433/tcp", 5000)
                    .Wait("profiles-sql-server", (service, count) =>
                    {
                        if (count > 10)
                        {
                            throw new FluentDockerException("Failed to wait for sql server");
                        }

                        using (var connection = new SqlConnection(CreateMasterConnectionStringBuilder().ConnectionString))
                        {
                            try
                            {
                                connection.Open();
                                return 0; //Zero and below means success
                            }
                            catch (Exception)
                            {
                                return 500; //The time to wait until next execution
                            }
                        }
                    })
                    .Build();

                this.containerService.Start();
            }
            catch (FluentDockerException ex) when (ex.Message.Contains("Error response from daemon: Conflict"))
            {
                this.Logger.LogInformation("MS SQL Server container already running.");
            }

            return Task.CompletedTask;
        }

[jchannon]

Have just tried the new release and seems well!

Thanks a lot!

On Fri, 31 May 2019 at 14:50, Mario Toffia [e-mail] wrote:

@jchannon https://github.com/jchannon Can you have a go on your code with the v2.6.8 and see if it fixes your case? So I may close this if it works.

Cheers, Mario

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mariotoffia/FluentDocker/issues/86?email_source=notifications&email_token=AAAZVJXR5JG6FRANCIKUHOTPYEUKDA5CNFSM4HRFVHH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVIVKA#issuecomment-497715880, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAZVJRB7SKMPJSZVKF2FZLPYEUKDANCNFSM4HRFVHHQ .

[yreynhout]

@jchannon they are independent in the sense that you register them one after the other, but upon starting the container, from reading the code, they seem to be executed as a sequence. Meaning, first WaitForPort then WaitForLambda.