Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PDF export should not export the tab bar

See original GitHub issue

Description

PDF export currently exports the tab bar. It should not.

Steps to reproduce

write stuff
make sure tab bar is visible
export to PDF

Expected behavior: [What you expected to happen] PDF output should be a clean page without any UI elements.

Versions

Mark Text: 0.12.20
OS: macOS

Issue Analytics

State:
Created 5 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

1dancookcommented, Jun 19, 2018

@jkrzefski that solution will probably result in some unwanted behavior as we have now. Whatever is being used now to render a PDF is basically doing a one page screenshot. When you have multiple pages etc. it won’t work. As @fxha has suggested a proper conversion library should be used instead.

Have a separate theme/style sheet applied (rather than what is used for the UI) is absolutely ideal as you have suggested @jkrzefski.

Lots of issues can be solved with the proper library. Look at you #355 #354 #349 #360 👀

1reaction

jkrzefskicommented, Jun 18, 2018

I assume the current view (including theme, sidebar, tabs, etc.) is just rendered by a pdf tool. If that is true, I think a solution would be to make a dedicated view for exports only with no ui-elements and a standardized theme setting and let that be rendered by the pdf tool.