CRM demo unable to clear filter form when clicking ⦻ in Firefox

What you were expecting:

I expect clicking the cross button in filter form should clear the filter

What happened instead:

Clicking on the cross button in filter form does not clear the filter Only clicking on the filter item text clears the filter This only happens in Firefox (Chrome and Edge seems work fine)

Steps to reproduce:

Go to https://marmelab.com/react-admin-crm/#/contacts?filter={"sales_id"%3A0%2C"status"%3A"cold"%2C"last_seen_lte"%3A"2022-04-01T05%3A00%3A00.000Z"}&order=DESC&page=1&perPage=25&sort=last_seen Click on the cross button next to Before this moth and the filter cannot be cleared. (Only Firefox has this issue) Click on the Before this moth text clears the filter.

Other information:

Environment

• React-admin version: 4.0.0
• Last version that did not exhibit the issue (if applicable):
• React version:
• Browser: Firefox 99
• Stack trace (in case of a JS error):

[slax57]

I still can’t figure out why I can’t reproduce on my end, even knowing where to click. Anyway, your analysis makes sense to me, so I approved your PR. Let’s just wait for @djhi to approve it as well 🙂

[slax57]

@smeng9 I believe this might be linked to the localstorage as well. The problem might come from the fact that this filter implies today’s date. The quick filter is only marked active if the filter currently applied is exactly the same. In your url, the date was a few days early, that’s why I think it is normal for the filter to be marked as inactive. The fact that is was active on your end might come from matching residual data. If you clear localstorage, refresh the webpage, and try pasting your original link again, I believe you will notice the same behaviour as me.