hooks: useUpdate onError signature typescript issue

Since the v4 upgrade of react-admin, I have the following typing issue on the useUpdate function when I try to access the error.message property of the parameter provided by the onError function:

TS2571: Object is of type 'unknown'.
    23 |     {
    24 |       onError: (error) => {
  > 25 |         notify(`Error while updating: ${error.message}`);
       |                                         ^^^^^
    26 |       }
    27 |     }
    28 |   )

I also try to specify the type of the error like that: (error: Error) => ..., but this leads to the following another error:

TS2322: Type '(error: Error) => void' is not assignable to type '(error: unknown, variables: Partial<UseUpdateMutateParams<RaRecord>>, context: unknown) => void | Promise<unknown>'.
  Types of parameters 'error' and 'error' are incompatible.
    Type 'unknown' is not assignable to type 'Error'.
    22 |     },
    23 |     {
  > 24 |       onError: (error: Error) => {
       |       ^^^^^^^
    25 |         notify(`Error while updating: ${error.message}`);
    26 |       }
    27 |     }

Steps to reproduce:

1. Clone the referenced PR below
2. Run npm start

Related code:

Sandbox PR: https://github.com/soullivaneuh/react-admin-sandbox/pull/1

Other information:

Environment

• React-admin version: v4.0.3
• Last version that did not exhibit the issue (if applicable): v3
• React version: v18

[soullivaneuh]

@slax57 I found a way to resolve the issue: https://github.com/marmelab/react-admin/pull/7698

Would you mind take a look? 😃

[soullivaneuh]

@slax57 Well… 🙃

Next time I’ll re-read my copy/paste, thanks! 😉

My setup:

const [setup, { isLoading }] = useUpdate(
  'users',
  {
  },
  {
    onSuccess: () => {
      refresh();
    },
    onError: (error) => {
      const message = error instanceof Error ? error.message : error instanceof String ? error : undefined;
      notify(`Echec : ${message}`, {
        type: 'error',
      });
      refresh();
    },
  },
);

Works! However, this double ternary shows indeed the need of a stronger typing to be provided by useUpdate.