Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RFC: Replace missing/default with default_load/default_dump/default

See original GitHub issue

Quoting @deckar01 in https://github.com/marshmallow-code/marshmallow/issues/775#issuecomment-382130144:

It does seem arbitrary for default to only be used for serialization. It isn’t immediately obvious that missing is the deserialization complement. It would be nice if there was a little more symmetry here. Maybe something like default_load, default_dump, and default to set both at once.

Issue Analytics

State:
Created 5 years ago
Reactions:2
Comments:11 (11 by maintainers)

Top GitHub Comments

4reactions

lafrechcommented, Oct 12, 2018

So should it be default_load and default_dump only?

If we do that we can keep and deprecate the old names:

missing (deprecated) -> load_default
default (deprecated) -> dump_default

(I prefer load_default to default_load.)

1reaction

sloriacommented, Oct 14, 2018

Aside from breaking users’ code, I’m also concerned about the maintenance burden for libraries that support both marshmallow 2 and 3. webargs, apispec, and environs will probably be affected by this change. I’m sure there are others.