question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Modernize codebase

See original GitHub issue

Before starting on new complex features, I would like to spend some time modernizing the codebase. The project was created with React 0.11 or something, and since, a lot of things changes, in best practices, APIs, etc.

Everything is on the table, from status quo to rewriting the whole thing.

Big ideas:

  • And what about Next.js / Nuxt.js? Is it a good idea with Electron?
  • If we stick with React:
    • Move to FC, more hooks, less classes
    • Get rid of Bootstrap completely, use Reakit for accessible components?
    • Update ESLint rules
    • Move to redux-toolkit
  • Move more business logic to the main process
  • Add tests
    • ~Unit-tests for reducers (via Jest)~ setup done
    • Integration / E2E tests with Cypress
  • Create binaries on GitHub actions
    • macOS code-signing
  • Electron
    • Get rid of electron.remote

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:5
  • Comments:8 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
martpiecommented, Jun 22, 2021

Cypress is the way to go for e2e tests right now, and I would not see myself using anything else.

The reason I’m not starting this big thing now is because I am thinking on a UI-focused update, and it would not make a lot of sense to write a lot of integration/e2e tests to update them just after this work is done.

But this is definitely on my todo list.

1reaction
martpiecommented, Jun 24, 2021

I don’t believe in component testing (it’s often really badly done).

Unit for utils/pure functions + e2e should be more than enough

Read more comments on GitHub >

github_iconTop Results From Across the Web

Why it's Crucial to Modernize Your Codebase
Modernizing a codebase is by no means a one size fits all exercise. The systems you have in place, how and when they...
Read more >
Understanding and Modernizing a Legacy Codebase
In this article, I will outline the steps our team took to onboard ourselves to work on an unfamiliar codebase, and how we...
Read more >
Stabilize, Modularize, Modernize: Scaling Slack's Mobile ...
When do you need to overhaul a large code base to address tech debt? What is the best way to address widespread inconsistencies...
Read more >
What's the best way to upgrade an outdated codebase ...
Ask an expert: What's the best way to upgrade an outdated codebase? Monterail's head of technology prioritizes flexibility and sustainability via ...
Read more >
Making the Case for an Investment in Modernizing Your ...
Navigating the tricky terrain of securing your board's buy-in starts with landing quick wins and learning to speak their language.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found