setLocale in express 4 with no cookies

Hi I want to set the locale for every request based on the x-locale request header. So in the API middleware, I check for the x-locale and, if it exists, I do i18n.setLocale(x_locale_header_value). But just after doing that, I call i18n.getLocale() and I always get the default locale (en in this case).

This is necessary for me as I use (just once throughout the API) a handlebars template which is always translated to the same language: default locale ‘en’.

To be honest, I don’t know whether or not I am doing something wrong and/or missing something. I’ve checked the i18n.init method documentation and issues but I don’t use cookies or param language at all, so it doesn’t have effect on the API.

So, any hint is welcome 😃

Cheers!!

[mashpie]

i18n.__('sting_to_translate') dispatches from global object. Doing so will lead to concurrency issues while binding to req sticks it’s locale setting to that single request only, which is the only way to ensure correct translations for each and every request handled.

So I strongly advise local usage like so:

i18n.setLocale(req, locale) // sets all of req, res and res.locals

// [...]

req.__('sting_to_translate') // or
res.__('sting_to_translate') // or
res.locals.__('sting_to_translate')

[telekosmos]

OOOOOK!! Clear explanation!!!

If everything seem to be working fine now (no so many translations performed in my API), what you say makes loads of sense. I knew I was doing something ‘no well’ altogether ☺️ .

Thanks!!!