RequestClient receives TimeOutException instead of RequestFaultException

Is this a bug report?

Update: I’m not sure

Can you also reproduce the problem with the latest version?

Yes

Environment

1. Operating system: Windows 10
2. Visual Studio version: Visual Studio 2017
3. Dotnet version: .NET Framework 4.6.2

Steps to Reproduce

Given following Code:

using System;
using System.Security;
using System.Threading.Tasks;
using MassTransit;

namespace ConsoleApp4
{
    class Program
    {
        private static string QUEUE_NAME = "some.test.queue";

        static void Main(string[] args)
        {
            var bus = Bus.Factory.CreateUsingRabbitMq(sbc =>
            {
                var host = sbc.Host(new Uri("rabbitmq://localhost:/"), h =>
                {
                    h.Username("guest");
                    h.Password("guest");
                });

                sbc.ReceiveEndpoint(host, QUEUE_NAME, endpoint =>
                {
                    endpoint.Consumer<MyMessageConsumer>();
                });
            });

            Task.WaitAll(bus.StartAsync());

            var requestClient = bus.CreateRequestClient<MyMessage, MyResponse>(new Uri($"rabbitmq://localhost:/{QUEUE_NAME}"), TimeSpan.FromSeconds(5));

            try
            {
                var result = requestClient.Request(new MyMessage {Value = "Hello, World."}).GetAwaiter().GetResult();
                Console.WriteLine("Got Result from Service: {0}", result.Value);
            }
            catch (Exception ex)
            {
                Console.WriteLine("got exception {0}", ex.GetType());
                // TimeOut-Exception instead of RequestFaultException?
            }
            
            Console.ReadLine();
            Task.WaitAll(bus.StopAsync());
        }
    }

    class MyMessageConsumer : IConsumer<MyMessage>
    {
        public Task Consume(ConsumeContext<MyMessage> context)
        {
            // throw a readable exception, which the request-client should read
            throw new SecurityException("Client should please read this");
            
            // return context.RespondAsync(new MyResponse { Value = context.Message.Value });
        }
    }

    class MyMessage
    {
        public string Value { get; set; }
    }

    class MyResponse
    {
        public string Value { get; set; }
    }

}

Expected Behavior

The RequestClient should get a RequestFaultedException, with the actual exception in it.

Actual Behavior

A Timeout-Exception occurs instead of a RequestFaultedException

This worked in 3.5.7 before updating to 5.3.2 (i know, big step). We’re using the request-client on many, many places in our code and our GlobalExceptionHandler handled these RequestFaults before, and now it can’t because a timeoutexception occurs instead.

Update:: My sample throws a timeoutexception too, on version 3.5.7, so I’m not sure, whats happening…

Reproducible Demo

See Steps to Reproduce Issue https://github.com/MassTransit/MassTransit/issues/1006 seems to be identical.

[phatboyg]

Yes, any blocking code in the async/TPL world causes random issues.

[bschaeublin]

closing this, as it seems I fixed the issue at our code-base with refactoring the “async” code and removing all the blocking .result code.

Thank you!