Support returning extension outputs
See original GitHub issueWhile preparing #21, I discovered that browser wasn’t actually returning extension results due to some weird issue with navigator.credentials.create()
/get()
returning a credential
with non-enumerable properties, so the spread operator was ineffective.
Anyway after some more digging it turns out that TypeScript’s AuthenticationExtensionsClientInputs and AuthenticationExtensionsClientOutputs definitions are wildly out of date, especially due to a recent WebAuthn spec change that removed a bunch of outdated extensions. Therefore I need to upgrade browser to support returning the results of getClientExtensionResults()
to support the list of extension currently defined in the spec:
- appid
- appidExclude
- uvm
- credProps
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:10 (6 by maintainers)
Top Results From Across the Web
E1: ORCH: Unable to Return Output Of A Logic Extension ...
When runing the orchestration more than once, it fails. Once the AIS server cache is refreshed manually, the Orchestration again works the ...
Read more >How to install and manage Azure CLI extensions
The extension command will return a command-not-found error if the extension is not installed. Azure CLI Copy. Try It.
Read more >Lambda Extensions API - AWS Documentation
Use the extensions API to create extensions that integrate code with the Lambda execution environment.
Read more >Prevent html entity encoding in output of tag extension
I'm creating a tag extension which needs to output some javascript. I am returning the following array, which comprises of 3 different ...
Read more >Output Extensions - Grafana k6
Output Extensions · To support a time-series database not already supported · To add derived metrics data for storage · To filter metrics...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@Moumouls PR #94 just landed and has been published as v2.1.0. @simplewebauthn/browser@2.1.0 will now return back the value of
credential.getClientExtensionResults()
as the newclientExtensionResults
property on the values that are returned by bothstartAttestation()
andstartAssertion()
.Extension support is only partially functional.
generateAttestationOptions()
andgenerateAssertionOptions()
accept anextensions
argument that gets passed straight through to the returned object without manipulation. There shouldn’t be any issues with passing extensions to authenticators, includingtxAuthSimple
andtxAuthGeneric
(which I think are now officially deprecated, for what it’s worth?).Where things fall down is getting the resulting extension output back to the RP so that they can be used. @simplewebauthn/browser still needs to be updated to return the return value from
getClientExtensionResults()
.