Error codes aren't passed from Git subcommand

🐛 Bug Report

When meta-git fails it doesn’t seem to pass the error code back.

To Reproduce

Steps to reproduce the behavior:

• Run any invalid Git command meta git blah blah for example.

Expected behavior

Should pass the error back, instead it does nothing.

Current behavior:

Expected behavior would be something like:

[mateodelnorte]

And thus we arrive at why it’s currently not the default. 😉

Personally, I’m fine leaving things as is and letting people writing scripts add the extra flags when error codes are required.

On Sun, Feb 9, 2020 at 12:29 PM Ameer A. [e-mail] wrote:

@mateodelnorte https://github.com/mateodelnorte there could be a downside for setting exit on aggregated error on all subcommands 🤔 say you only have a set of changes on some of the child repos and you wanna commit them, then there would be multiple errors on all child repos that don’t have any change them (since Git doesn’t like it)

Would it be reasonable to assume in such case the usage would have either exclude or include flags set? Or should the command be aware enough not to run in these child repos 🤔

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mateodelnorte/meta/issues/212?email_source=notifications&email_token=AAEHOX4ZVWPNTGYVHUHMUTLRCBCN3A5CNFSM4KPYSV42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGT5SI#issuecomment-583876297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEHOX6BXR5KBEGTTM5OTLDRCBCN3ANCNFSM4KPYSV4Q .

[mateodelnorte]

I think it should be the default for all. Let’s get the PR up and play with it, and we can decide whether it will be breaking or not. *It’s probably breaking tho.