question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ProgressIndicator] Property indicatorWidth redundant/missleading

See original GitHub issue

Is your feature request related to a problem? Please describe.

The following applies to the LINEAR indicator:

Using the ProgressIndicator property indicatorWidth changes the height of the ProgressIndicator which is not obvious from its name. In addition the height should rather be controlled by the regular height property on the given layout params. Atm the indicatorWidth is used as a fix constant wich makes it unnecessarily complicated to control the View height with layout params.

Describe the solution you’d like

Remove misleading indicatorWidth in favor of the layout params height

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
hunterstichcommented, Jul 20, 2020

Hey @mpost,

Thanks for the feedback. Can definitely see where you’re coming from. If I remember correctly, I think indicatorWidth was the most universal property name considering it also maps to the “strokeWidth” of a circular indicator, but @pekingme might have some more info. I’ll bring this up with the team.

0reactions
mpostcommented, Jul 29, 2020

Thanks for the additional info. I understand the constraints applied to the layout behavior in regards to the drawable used by the view. Therefore it could be argued that the intrinsic size has precedence over any layout height given.

Renaming the property to indicatorSize is a good step.

Read more comments on GitHub >

github_iconTop Results From Across the Web

The Reusable Progress Indicator - Rubberduck News
If you want to reuse that code in the same project, you're out of luck – either you duplicate the “indicator” code and...
Read more >
Circular Progress Indicator ignores width/height attributes and ...
I spread chain these 4 progress bar in constrait layout, but them don't scale. It looks like they are still having deafult 24dp...
Read more >
Displaying Progress in a Notification | Android Developers - MIT
Display a Fixed-duration Progress Indicator. To display a determinate progress bar, add the bar to your notification by calling setProgress(max, progress, false) ...
Read more >
Estimating the Genuine Progress Indicator before and during ...
In addition to measuring economic progress, these alternative indicators also factor-in social and environmental dimensions (Talberth et al., 2006) and can ...
Read more >
How to build an SVG circular progress component using ...
In this tutorial, we'll demonstrate the creation of a simple, customizable, easy-to-use circular progress indicator for React using SVGs.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found