question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken compatibility with Google Closure Compiler

See original GitHub issue

1.0.0 breaks compatibility with Google Closure Compiler. I think this is unfortunate to break not only GCC users but whole ClojureScript community as well. It is failing on export * from ... syntax in index.js files, because it’s not supported in GCC. Is it possible to not use imports from /index modules and instead to be explicit what concrete module (eg. /component) is actually imported? I tested it by hand editing package files and it works again. I hope this will also help with tree-shaking for other consumers of this amazing library.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
abhiomkarcommented, Apr 21, 2019

As per my knowledge, PR #4594 by @moog16 fixes this issue.

1reaction
kfranqueirocommented, Mar 11, 2019

That’s a good point. We purposely avoid referencing index from foundations/adapters for the sake of wrapper libraries which shouldn’t need index or the component, but we allowed referencing index from components under the assumption that if you’re using it in the context of vanilla MDC Web, there shouldn’t be an issue.

So I guess avoiding referencing index from component files is a third option.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Frequently Asked Questions | Closure Compiler
The Closure Compiler works only on files that contain only JavaScript. Can I use the Closure Compiler together with other JavaScript minifiers?
Read more >
Google closure compiler gives error - javascript - Stack Overflow
I'm using google closure compiler to obfuscate javascript code using this website. When I use simple optimization this works but when I use...
Read more >
Closure Compiler v20140110 released! - Google Groups
http://code.google.com/p/closure-compiler/wiki/Releases Changes: ... Add support for a strict-mode compatible version of goog.base. ... Is broken.
Read more >
The Closure Compiler and Svelte - SyntaxSuccess
The closure compiler is an advanced JavaScript optimizer created by Google to reduce the size of JavasScript bundles beyond what's possible ...
Read more >
google-closure-compiler - npm
Check, compile, optimize and compress Javascript with Closure-Compiler. Latest version: 20221102.0.1, last published: 10 days ago.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found