Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Screenshot Testing - golden screenshots should be in repo

See original GitHub issue

Screenshot Testing - golden screenshots should be in repo according to docs but *.golden.png is in .gitignore:

https://github.com/material-components/material-components-web-react/blob/master/.gitignore#L9

Issue Analytics

State:
Created 5 years ago
Comments:10 (6 by maintainers)

Top GitHub Comments

1reaction

bonniezhoucommented, Jul 16, 2018

The golden.png files are stored in Google Cloud Storage and visible publicly via this URL:

https://storage.googleapis.com/screenshot-uploads/<path>/<to>/<file>.html/<golden-screenshot-hash>.golden.png

where <golden-screenshot-hash> is found in the golden.json file, and <path>/<to>/<file> is the path to the HTML file relative to the /test/screenshot folder.

Check out the newly updated screenshot tests doc for more details!

0reactions

moog16commented, Jul 9, 2018

@schliflo I think we can actually make the images publicly available for download. Then you and others will be able to download the images and run tests against them. You just wouldn’t be able to upload images. But we could do that when/if there are changes that require that step.

Also we noticed that some of the verbiage in the https://github.com/material-components/material-components-web-react/tree/master/test/screenshot/README.md is not accurate. We will update!