Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Regression in federation sender instance calls to get joined profile

See original GitHub issue

v1.61.1 release dramatically reduced federation sender calls to the _get_joined_profile_from_event_id cache (see: https://github.com/matrix-org/synapse/pull/12955#issuecomment-1162800438). This seems to have returned in 1.63.1, the jump below is when we upgraded from 1.61.1 -> 1.63.1:

Issue Analytics

State:
Created a year ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

richvdhcommented, Aug 15, 2022

Out of interest - how many federation senders are running on matrix.org? I wonder if something is weird about our setup; we have 3x of them each doing ~1k/s on this cache.

sorry, missed this. matrix.org apparently has 20 federation senders, handling a total of around 100 outgoing federation PDUs per second. But note that the code that hits get_joined_hosts is done before the work is sharded (ie, each of the federation senders does the lookup for every event).

0reactions

richvdhcommented, Oct 10, 2022

It’s also plausible that we’ve sped up event persistence sufficiently in large rooms that it now is faster than doing get_joined_hosts in large rooms?

Possibly…

Is it possible that we now avoid pulling all of the state out of the database during the event-creation path… right up until we attempt to cache_joined_hosts_for_event, when we’ll suddenly need to pull the entire membership list out of the database?

Top Results From Across the Web

`user_directory.notify_new_event` throws exception whenever ...

Found while running the MSC2716 Complement test suite (COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement .

CHANGES.md · 2d295a4be92894d18d71512548db8629a3ed4b50 ...

This release fixes a regression in Synapse 1.32.0 that caused connected Prometheus instances to become unstable. However, as this release is still subject ......

Federated Identity Management and Web Services Security

advantage of identity federation to improve customer experiences, reduce costs, and improve overall security. This scenario, for example, involves two large.

CMDB Federation Specification (DSP 0252) - DMTF

The federated CMDB described in this specification is a collection of services and data repositories that contain configuration and other data ...

Category: Releases | Matrix.org

Today we have released Synapse 1.21.2, which fixes a couple of minor bugs that ... Improved federation sender logic (resend retries, backoffs, blacklisting, ......