Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Angular version 10 - CommonJS import warnings

See original GitHub issue

Describe the bug

When building with the new angular version 10 angular-calendar triggers several warnings caused by using CommonJS dependencies instead of ecmascript module.

For example: .../app.module.ts depends on angular-calendar/date-adapters/date-fns. CommonJS or AMD dependencies can cause optimization bailouts.

You can read more about why this might be a problem at angular.io. I was wondering wether this could be fixed as it may improve bundle sizes significantly when building.

Minimal reproduction of the problem with instructions

Update project to angular 10.0 and run ng build.

Screenshots

Versions

@angular/core: 10.0.0
angular-calendar: 0.28.16
Browser name and version: any

Issue Analytics

State:
Created 3 years ago
Reactions:3
Comments:8 (3 by maintainers)

Top GitHub Comments

2reactions

manu2495commented, Sep 12, 2020

nice ! it works for me right now

2reactions

mattlewis92commented, Sep 12, 2020

Thank you so much. The update did remove so many warnings. There is only one warning that’s remaining though.

WARNING in frontend\node_modules\angular-draggable-droppable__ivy_ngcc__\fesm2015\angular-draggable-droppable.js depends on ‘@m attlewis92/dom-autoscroller’. CommonJS or AMD dependencies can cause optimization bailouts.

I’ve just noticed that as well when testing, please give 0.28.18 a go, it should get rid of it 😄