question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Class ref modal opening doesn't completely work

See original GitHub issue

I’m submitting a … (check one with “x”)

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

If you want to inject a Component or a TemplateRef into a modal, the modal will only display the static content, not all the dynamic projected content as data provided through @Input() or {{ ... }}.

Expected behavior

Display the entire Component or TemplateRef as it will normally be.

Reproduction of the problem

Bug reproduction here on StackBlitz.

What is the motivation / use case for changing the behavior?

If a user uses the lib and wants to open a modal and inject into it an existing component with dynamic data projection, he couldn’t.

Please tell us about your environment:

Not relevant.

  • Smart Modal version: 0.8.x

7.2.1

  • Angular version: 2.0.x

8.2.3

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all | TypeScript X.X | ES6/7 | ES5] Not relevant.

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:3
  • Comments:8 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
GrzegorzTokarzcommented, Dec 30, 2019

I have made roughly working solution, but haven’t got time to fix unit tests https://github.com/GrzegorzTokarz/ngx-smart-modal/tree/feature/dynamic-content

1reaction
GrzegorzTokarzcommented, Jan 27, 2020

@maximelafarie @LouisAugry here is PR with rough work, i’ll rebase changes onto current master and clean up it a bit. It was just some quick solution for one of my projects 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Bootstrap modal not displaying - Stack Overflow
to check, Go to your modal fade class on browser and then check if there is any custom file comes on top. such...
Read more >
JavaScript - Bootstrap
The modal plugin toggles your hidden content on demand, via data attributes or JavaScript. It also adds .modal-open to the <body> to override...
Read more >
How to Open and Close a React-Bootstrap Modal ... - Pluralsight
1import React from "react"; 2import { Modal, Button, ... Inside the App component, add a button that will open up the modal.
Read more >
<Modal/> Component - React-Bootstrap
Bootstrap only supports one modal window at a time. Nested modals aren't supported, but if you really need them, the underlying @restart/ui library...
Read more >
modal.show not working - MSDN
modal.show not working RRS feed ... and when user clicks on link dialog opens ... <div id="login-modal" class="forms-modal modal fade" ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found