inconsistent vertical location

I’m submitting a … (check one with “x”)

[ ] bug report => search github for a similar issue or PR before submitting
[x ] feature request
https://github.com/biig-io/ngx-smart-modal/issues/new
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior My current table is quite long and when I want to display modal, I have to set $dialog-position-top: 70%; which is weird since 70% is fine.

But then, when my table list is small, I can’t see it anymore unless I reset the top position to much less value.

Expected behavior I was hoping the top position simply calculates from the actual screen, regardless of page content. So 50% would place it at center, 0% at the top etc, 20px. Regardless, I thought it calculates from the screen, instead of the content which I have no control over at all.

In fact, adding position:fixed to the core scss file does the trick.

Reproduction of the problem

What is the motivation / use case for changing the behavior?

It would be nice and easier to either have percentage or pixel or even pre-defined settings like ‘center’ would mean center of the screen regardless of the content on display

Please tell us about your environment:

Windows 7. Webpack. NPM. Apache

• Smart Modal version: 0.8.x

• Angular version: 2.0.x

5

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome and Firefox

• Language: [all | TypeScript X.X | ES6/7 | ES5] ES6

[iconicsammy]

Thanks Max! Indeed working well for my angular 5. Will keep an eye for when you make it Angular 6 ready as well…a few edits seem to make it work. Thanks a bunch!

On Mon, Jul 16, 2018 at 2:28 PM Maxime Lafarie [e-mail] wrote:

Hello @iconicsammy https://github.com/iconicsammy, yes it has been fixed in the brand new version 7.0.0!

You can now create a modal relative to a given element with the target option. More details in the readme in the Parameters / Options https://github.com/biig-io/ngx-smart-modal#parameters--options section.

Happy coding! 🖖

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biig-io/ngx-smart-modal/issues/113#issuecomment-405231380, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3GGg57p6G8Lxv73JCR3JYFzxU270qGks5uHIcHgaJpZM4UQc5r .

– Sium, K Skype: issaammyy

“Nothing is impossible when you use your mind” Professor Proton

This email is sent from mobile phone. Sorry for spelling typos in advance.

[iconicsammy]

terrific. Already was working with it on Angular 6 until you make the necessary changes. Thanks a bunch. It is super awesome and smooth now.

On Tue, Jul 17, 2018 at 4:28 PM Maxime Lafarie [e-mail] wrote:

@iconicsammy https://github.com/iconicsammy as I previously said, the Angular 6 error was related to the rxjs peer dependency. It has been removed and from now you can use the 7.0.1 version of this library. 😎

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biig-io/ngx-smart-modal/issues/113#issuecomment-405602087, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ3GGl2y9aMTCDWW8n-XIusWsTrjdqIUks5uHfSdgaJpZM4UQc5r .

– Sium, K Skype: issaammyy

“Nothing is impossible when you use your mind” Professor Proton

This email is sent from mobile phone. Sorry for spelling typos in advance.