removeModal method doesn't remove ngx-smart-modal element from html dom

I’m submitting a …

[x] bug report
[ ] feature request
[ ] support request

Current behavior I use removeModal to be able to create new modal with new associated data (from https://github.com/biig-io/ngx-smart-modal/issues/173), but the corresponding ngx-smart-modal element is not removed from html. Is it the normal behavior or a bug? Everytime I open my modal, I do like this:

this.modalService.removeModal(MY_MODAL);
this.modalService.create(MY_MODAL, MyModalComponent)
   .setData(data)
   .open();

Expected behavior ngx-smart-modal element should be remove from html dom, but I’d like to hear that if it’s actually a feature or not.

Reproduction of the problem Use the above code to Open modals via class reference without declaring a ngx-smart-modal element in template.

What is the motivation / use case for changing the behavior? Prevent memory leak.

Please tell us about your environment:

• Smart Modal version: 7.4.0
• Angular version: 9
• Browser: Chrome
• Language: TypeScript

[alexsherekin]

Hi @maximelafarie. Have you already started to work on this issue? If not, I’d like to look into it. It seems to be a good first issue to start contributing in the project.

[maximelafarie]

Great work @alexsherekin, thank you for refactoring it! I’ll close this issue right after it’s released, I just have few things to fix before pushing a new release! 😉 Cheers! 🖖