Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ratio shows error in a-frame v0.5.0

See original GitHub issue

<a-entity
        geometry="primitive:plane;width:45;height:17;"
        look-at="[camera]"
        position="0 0 0"
        material="shader:html;target:#hide-info;transparent:true;ratio:width;opacity:1;">
      </a-entity>

If I set ratio in material, it shows me an error:

aframe-html-shader.js?2520:432 Uncaught (in promise) TypeError: Cannot read property 'width' of undefined
    at NewShader.__draw (eval at <anonymous> (app.js:1729), <anonymous>:432:41)
    at eval (eval at <anonymous> (app.js:1729), <anonymous>:566:18)

Issue Analytics

State:
Created 6 years ago
Comments:6

Top GitHub Comments

1reaction

derhuebiiicommented, Apr 5, 2017

Actually it’s even easier than I proposed, just replace the following:

 - var _el$getObject3D$geome = this.el.getObject3D('mesh').geometry.parameters;
+ var _el$getObject3D$geome = this.el.getObject3D('mesh').geometry.metadata.parameters;

1reaction

jason90929commented, Mar 24, 2017

I made it work! But I think I’m just using hard code to do what I want add these code into line 433 in dist/aframe-html-shader.js

 - var _el$getObject3D$geome = this.el.getObject3D('mesh').geometry.parameters;
 - var width = _el$getObject3D$geome.width;
 - var height = _el$getObject3D$geome.height;
 + const material = this.el.getAttribute('material')
 + const target = document.querySelector(material.target)
 + if (!target) return
 + const width = target.clientWidth / 4
 + const height = target.clientHeight / 4