Field has an invalid name on upgrading 1.0.5 to 2.0.4

I’m attempting to upgrade a database from 1.0.5 to 2.0.4 but the upgrade fails.

It doesn’t appear to like spaces in field names?

.\LiteDB.2.0.4\tools\LiteDB.Shell.exe .\database.db --upgrade .\database_v2.db --exit
Welcome to LiteDB Shell

Getting started with `help`

> open .\database.db
open "database.db" (v1.0.4)
> dump > C:\Users\Tim\AppData\Local\Temp\tmp73D3.tmp
> open .\database_v2.db
open "database_v2.db" (v2.0.4)
> dump < C:\Users\Tim\AppData\Local\Temp\tmp73D3.tmp
Field 'Transparent Dark' has an invalid name.
>

The upgraded database ends up with no entries in the problem collection.

Opening the old database it seems happy to dump it and I can even query the collection from the shell without upgrading.

I can’t post the exact content publically, but this gives an example of a collection entry that’s a problem on upgrade. There’s more content in each element in reality.

{
    "_id": {"$oid": "57fe86100dc86c3324b1a7c1"},
    "Name": "A Name",
    "Description": "Description",
    "Themes":
    {
        "Dark":
        {
            "Name": "Dark"
        },
        "Light":
        {
            "Name": "Light"
        },
        "Transparent Dark":
        {
            "Name": "Transparent Dark"
        }
   }
}

[mbdavid]

Hi guys, it’s a “simple” bug in this convertion. The problem is when 1.0.4 serialize your Dictionary there is validation in key (support any string). But, when you try deserialize in 2.x BsonDocument key must be validate from here:

https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Document/BsonDocument.cs#L51

v3 has no upgrade from v1 yet, but it’s on my plans.

For now, change this method to returns always true.

[DeanVanGreunen]

@todo xX-MLG-Xx extend upgrade command for shell and litedb engine